On Wed, Apr 23, 2014 at 3:26 PM, Thomas Graf <[email protected]> wrote:
> On 04/23/2014 05:49 PM, Pravin B Shelar wrote:
>>
>> mask caches index of mask in mask_list.  On packet recv OVS
>> need to traverse mask-list to get cached mask.  Therefore array
>> is better for retrieving cached mask.  This also allows better
>> cache replacement algorithm by directly checking mask's existence.
>>
>> Signed-off-by: Pravin B Shelar <[email protected]>
>
>
> LGTM
>
> Acked-by: Thomas Graf <[email protected]>
>
>
>
>> +       if (old)
>> +               call_rcu(&old->rcu, mask_array_rcu_cb);
>
>
> At some point we should simply backport rcupdate.h to make kfree_rcu()
> available and get rid of all these wrappers.
>
This is done for compatibility, older kernel does not have this API
and there is not easy way of back-porting it.

Thanks for review I pushed first three patches to master.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to