On Apr 29, 2014, at 2:51 PM, Ben Pfaff <[email protected]> wrote: > On Fri, Apr 25, 2014 at 08:49:10AM -0700, Jarno Rajahalme wrote: >> Allocate struct rule_actions and the space for the actions at once. >> This reduces one memory indirection and helps reduce cache misses >> visible in perf annotations. >> >> Fix some old comments referring to ref count, since we now use RCU for >> this. >> >> Enforce constness of the actions throughout the code. >> >> Signed-off-by: Jarno Rajahalme <[email protected]> > > This would be a lot easier to review as one patch that makes the > substantive changes and another one that updates all the consts. > > ofpact_check__() takes nonconst ofpacts because of the comment: > * Modifies some actions, filling in fields that could not be properly set > * without context. */ > Similarly for ofpacts_check(). So it's better to keep those nonconst > in my opinion. >
Thanks for the review! I forgot about the changing of the actions in ofpact_check__(). I now changed these back, and consequently reverted some of the struct ofpact pointers in ofp-util.h back to non-consts as well. > Acked-by: Ben Pfaff <[email protected]> Pushed, Jarno _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
