On Fri, Apr 25, 2014 at 10:24 AM, Ben Pfaff <[email protected]> wrote:
> The test added in this commit would have caught the bug fixed by commit
> 96be8de595150 (bridge: When ports disappear from a datapath, add them
> back.). With that commit reverted, the new test fails.
>
> Signed-off-by: Ben Pfaff <[email protected]>
> - error = get_port_by_number(dp, port_no, &port);
> - if (error) {
> - return error;
> - }
> -
> hmap_remove(&dp->ports, &port->node);
> seq_change(dp->port_seq);
> if (netdev_is_pmd(port->netdev)) {
> @@ -876,7 +877,6 @@ do_del_port(struct dp_netdev *dp, odp_port_t port_no)
> }
>
> port_unref(port);
Dont we need any mutex for unref above?
> - return 0;
> }
>
I did not compile test it because it does not apply right now. But the
logic looks right.
Acked-by: Gurucharan Shetty <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
