Good catch. I've fixed it and will merge soon. Ethan
On Thu, Aug 14, 2014 at 9:49 AM, Ben Pfaff <[email protected]> wrote: > On Wed, Aug 13, 2014 at 06:46:17PM -0700, Ethan Jackson wrote: >> This patch reorganizes ofproto-dpif in preparation for future patches >> which allow direct upcall processing from dpif-netdev. The main goals >> are to share as much code as possible between the dpif-linux and >> dpif-netdev upcall paths. Additionally, to avoid confusing the >> dpif-netdev fast path, the packet processing path should treat packets >> and struct flow's as const. >> >> Signed-off-by: Ethan Jackson <[email protected]> > > recv_upcalls() calls upcall_receive() and if that fails it jumps to > cleanup to call upcall_uninit(). However, my reading of > upcall_receive() is that in its only failure case the upcall is not > properly initialized to call upcall_uninit(). For example, I believe > that the upcall's xout_initialized member is not initialized at that > point. I think that this error case should jump to free_dupcall > instead. > > Acked-by: Ben Pfaff <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
