On Thu, Aug 21, 2014 at 10:45:14AM -0700, Ben Pfaff wrote:
> OpenFlow 1.2 and later have "experimenter errors".  The OVS implementation
> was buggy in a few ways.  First, a bug in extract-ofp-errors prevented
> OF1.2+ experimenter errors from being properly decoded.  Second,
> OF1.2+ experimenter errors have only a type, not a code, whereas all other
> types of errors (standard errors, OF1.0/1.1 Nicira extension errors) have
> both, but extract-ofp-errors didn't properly enforce that.
> 
> This commit fixes both problems and improves existing tests to verify that
> encoding and decoding of experimenter errors now works properly.
> 
> This commit also fixes the definition of OFPBIC_DUP_INST.  It claimed to
> have an OF1.1 experimenter error value although OF1.1 didn't have
> experimenter errors.  This commit changes it to use a Nicira extension
> error in OF1.1 instead.
> 
> Signed-off-by: Ben Pfaff <b...@nicira.com>

I'd appreciate a review for these patches.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to