Alin, Thanks for incorporating all the comments. Does it get any better if you don't do the renaming in this patch?
I looked at the patch and there's only deleted code in dpif-linux.c and new code in dpif-netlink.c. It is hard to do any comparison about what was changed. I am OK with this though. One suggestion is we could keep the old file name itself, and commit the patch, and take care of renaming the file in a subsequent patch. You could do 2 patches in a series. That would work too. thanks, -- Nithin On Sep 17, 2014, at 6:37 PM, Alin Serdean <aserd...@cloudbasesolutions.com> wrote: > Unfortunately there some special characters in dpif-linux.c > that do not allow me to send the patch normally. > > Trying via attachment. > > Short description: > The patch contains the necessary modifications to compile and also to run > under MSVC. > > Added the files to the build system and also changed dpif_linux to be under > a more generic name dpif_windows. > > Added a TODO under the windows part in case we want to implement another > counterpart for epoll functions. > > v2. Changed filename dpif-linux.c/h ==> dpif-netlink.c/h > Fixed style issues. > Renamed dpif_linux_vport* to dpif_netlink_vport* > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
