It's OK to use a fairly high rate limit, say 10 times per minute. Here is another issue that I just noticed: list_size() is expensive because it is O(n) in the length of the list. Can you think of another way that avoids this?
On Fri, Sep 19, 2014 at 11:05:38AM -0700, Alex Wang wrote: > I'm okay with changing it to INFO with RL. > > The reason i do not want to use RL is that at very large scale, most logs > will > be suppressed. And i'm lazy to run disable-rate-limit on particular > modules. > > > On Fri, Sep 19, 2014 at 10:45 AM, Ben Pfaff <b...@nicira.com> wrote: > > > On Thu, Sep 18, 2014 at 03:18:13PM -0700, Alex Wang wrote: > > > This commit adds a warning message to warn the excessive backlog > > > for jsonrpc. > > > > > > Signed-off-by: Alex Wang <al...@nicira.com> > > > > I would make this an INFO or DBG message because in its current form > > it seems likely to alarm users unnecessarily. > > > > I suggest rate-limiting it. > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev