On Oct 15, 2014, at 2:48 PM, Ankur Sharma <[email protected]> wrote:
> Added the handlers for update_flags and set_etheraddr. > These handlers were needed for vswitchd bringup on windows > platform. > > Signed-off-by: Ankur Sharma <[email protected]> Can you pls. add a XXX comment or a regular comment in netdev_win_set_flag() and netdev_windows_set_etheraddr(), saying that the functionality is not implemented/required? Somoene casually browsing through the code should realize that the functionality is not required/implemented for Windows. Looks good otherwise. Acked-by: Nithin Raju <[email protected]> _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
