“rename … in …” -> “rename … as …”. Also, there is extra indentation in the 
commit message. Otherwise:

Acked-by: Jarno Rajahalme <jrajaha...@nicira.com>

On Nov 6, 2014, at 7:31 AM, Daniele Venturino <daniele.ventur...@m3s.it> wrote:

>        All other similar port_role_transition_sm states are named like this.
> 
> Signed-off-by: Daniele Venturino <daniele.ventur...@m3s.it>
> ---
> lib/rstp-common.h         | 2 +-
> lib/rstp-state-machines.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/rstp-common.h b/lib/rstp-common.h
> index cd43079..6e56958 100644
> --- a/lib/rstp-common.h
> +++ b/lib/rstp-common.h
> @@ -141,7 +141,7 @@ enum port_role_transition_state_machine {
>     PORT_ROLE_TRANSITION_SM_DESIGNATED_DISCARD_EXEC,
>     PORT_ROLE_TRANSITION_SM_ALTERNATE_PORT_EXEC,
>     PORT_ROLE_TRANSITION_SM_ALTERNATE_PORT,
> -    PORT_ROLE_TRANSITION_SM_ALTERNATE_AGREED,
> +    PORT_ROLE_TRANSITION_SM_ALTERNATE_AGREED_EXEC,
>     PORT_ROLE_TRANSITION_SM_ALTERNATE_PROPOSED_EXEC,
>     PORT_ROLE_TRANSITION_SM_BLOCK_PORT_EXEC,
>     PORT_ROLE_TRANSITION_SM_BLOCK_PORT,
> diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
> index 9357db5..5398f12 100644
> --- a/lib/rstp-state-machines.c
> +++ b/lib/rstp-state-machines.c
> @@ -1641,11 +1641,11 @@ port_role_transition_sm(struct rstp_port *p)
>             } else if ((all_synced(r) && !p->agree)
>                        || (p->proposed && p->agree)) {
>                 p->port_role_transition_sm_state =
> -                    PORT_ROLE_TRANSITION_SM_ALTERNATE_AGREED;
> +                    PORT_ROLE_TRANSITION_SM_ALTERNATE_AGREED_EXEC;
>             }
>         }
>         break;
> -    case PORT_ROLE_TRANSITION_SM_ALTERNATE_AGREED:
> +    case PORT_ROLE_TRANSITION_SM_ALTERNATE_AGREED_EXEC:
>         p->proposed = false;
>         p->agree = true;
>         p->new_info = true;
> -- 
> 1.8.1.2
> 

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to