[adding ovs-dev back, hope that's OK] On Tue, Jan 13, 2015 at 09:19:53PM +0000, Flynn, Dennis R (Dennis) wrote: > Just wondering if you have been able to make any progress on this. > We are very excited about the prospects of this being included in OvS 2.4
One place I've become a little hung up is parsing LLDP_TLV_MGMT_ADDR. I think that there's a bug in the length checking: I believe that CHECK_TLV_SIZE checks the total size of the attribute's value, but I think that the code here is passing the length of only the part of the TLV that it hasn't already passed through. If you could take a look at that then I'd appreciate it. Another thing that worries me a little is that there aren't any unit tests for LLDP decoding. Protocol parsing is always a little tricky to get right and it's always reassuring to have some tests for it. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
