Thx a lot for the review, I finally setup my first qemu powerpc debian
and run the test there~... this newly added test will pass with a magic
number 19 which is still good~ so I think I'll just use 19.
Thanks,
Alex Wang,
On Fri, Feb 27, 2015 at 10:09 AM, Joe Stringer <joestrin...@nicira.com>
wrote:
> Looks good, minor comments inline.
>
> On 27 February 2015 at 09:33, Alex Wang <al...@nicira.com> wrote:
> > This commit adds a new test for hash_bytes128() using single 128-bit
> > word. The test shows that there is no collision in all 17 consecutive
> > bits checks, which indicates the hash function is good.
> >
> > Signed-off-by: Alex Wang <al...@nicira.com>
> > ---
> > tests/test-hash.c | 100
> ++++++++++++++++++++++++++++++++++++++++++++++-------
> > 1 file changed, 88 insertions(+), 12 deletions(-)
> >
>
> It's 2015 now, so the copyright message at the top of the file can be
> updated.
>
> > static uint32_t
> > hash_words_cb(uint32_t input)
> > {
> > return hash_words(&input, 1, 0);
> > }
> > -
> > static uint32_t
> > jhash_words_cb(uint32_t input)
> > {
>
> Unnecessary whitespace change here.
>
Thanks, I'll address them,
> Acked-by: Joe Stringer <joestrin...@nicira.com>
>
>
> Did the patch to remove the "exit(1)" from check_word_hash() get
> posted/applied?
>
I'll send a separate patch~!
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
