Hi Ben,
We have completed our testing with your additional refinements and everything
looks good.
I have the following comments after reviewing your changes.
Once these are addressed to your satisfaction we are good to go with committing
these changes.
lib/lldp/lldp.c
- Remove lingering reference to POKE macro in comment
- Should lldp_tlv_end() check for null after call to ofputbuf_at()?
- lldp_send() - missing statement to set new h_lport.p_lastframe
Update Copyright statements adding '2015' in the following
- aa-structs.h
- lib/lldp/lldp.c
- lib/lldp/lldpd-structs.c
- lib/lldp/lldpd.c
- lib/lldp/lldpd.h
- lib/ovs-lldpd.c (Windriver)
Thanks,
Dennis
-----Original Message-----
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
Sent: Monday, February 23, 2015 12:20 AM
To: dev@openvswitch.org
Cc: Ben Pfaff
Subject: [ovs-dev] [PATCH 00/32] Auto-Attach series plus refinements
This is Dennis Flynn's auto-attach feature plus a number of refinements.
Dennis, will you take a look at it?
Thanks,
Ben.
Ben Pfaff (29):
ovs-vsctl: Fix misused casts.
lldp: Get rid of POKE macros in favor of inline functions.
lldp: Use x*alloc() functions instead of writing them out in-place.
ovs-lldp: Use correct printf specifiers.
lldp: Use OVS time functions.
lldp: Use "bool" for boolean variables.
lldp: Declare "bool" variables as type "bool".
lldpd-structs: Fix spelling error in message.
test-aa: Make variables local to this file static.
lldp: Change representation of ISID to uint32_t.
lldp-structs: Fix use of list of lldpd_aa_isid_vlan_maps_tlv.
lldp-structs: Fix use of list of struct lldpd_mgmt.
lldp-structs: Fix use of list of struct lldpd_port.
ovs-lldp: Use better types for ISID and VLANs.
lldpd-structs: Fix type of c_id member.
lldp: Miscellaneous coding style fixes.
ovs-lldp: Remove unneeded NULL checks on free().
lldpd: Remove obsolete comment.
lldpd: Use CONTAINER_OF instead of cast, for safety.
lldpd: Remove unused ALIGNED_CAST macro.
lldpd: Fix return value convention for "send" function.
lldp: Remove excessive parentheses.
lldp: Use ETH_ADDR_FMT.
lldpd: Remove unused members from struct lldpd.
lldpd-structs: Declare Boolean member as one bit, not two.
lldpd: Fix use of list of struct lldpd_chassis.
lldpd: Fix use of list of struct lldpd_hardware.
lldp: Remove unused definitions from headers.
lldp: Fully parenthesize some macro definitions.
Dennis Flynn (3):
auto-attach: Initial support for Auto-Attach standard
auto-attach: Add auto-attach support to ofproto layer
auto-attach: Add auto-attach support to bridge layer and command set
NEWS | 3 +
NOTICE | 13 +
debian/copyright.in | 15 +
lib/automake.mk | 12 +-
lib/bfd.c | 6 +-
lib/bfd.h | 2 +-
lib/cfm.c | 6 +-
lib/cfm.h | 2 +-
lib/lldp/aa-structs.h | 49 +++
lib/lldp/lldp-const.h | 230 ++++++++++
lib/lldp/lldp-tlv.h | 79 ++++
lib/lldp/lldp.c | 608 ++++++++++++++++++++++++++
lib/lldp/lldpd-structs.c | 126 ++++++
lib/lldp/lldpd-structs.h | 223 ++++++++++
lib/lldp/lldpd.c | 643 +++++++++++++++++++++++++++
lib/lldp/lldpd.h | 101 +++++
lib/odp-util.h | 1 +
lib/ovs-lldp.c | 962 +++++++++++++++++++++++++++++++++++++++++
lib/ovs-lldp.h | 104 +++++
ofproto/ofproto-dpif-monitor.c | 52 ++-
ofproto/ofproto-dpif-monitor.h | 3 +-
ofproto/ofproto-dpif-xlate.c | 34 +-
ofproto/ofproto-dpif-xlate.h | 8 +-
ofproto/ofproto-dpif.c | 98 ++++-
ofproto/ofproto-provider.h | 80 +++-
ofproto/ofproto.c | 80 +++-
ofproto/ofproto.h | 16 +
tests/auto-attach.at | 7 +
tests/automake.mk | 6 +-
tests/ovs-vsctl.at | 2 +
tests/test-aa.c | 313 ++++++++++++++
tests/testsuite.at | 1 +
utilities/ovs-vsctl.8.in | 27 +-
utilities/ovs-vsctl.c | 194 ++++++++-
vswitchd/bridge.c | 275 +++++++++++-
vswitchd/vswitch.ovsschema | 29 +-
vswitchd/vswitch.xml | 64 +++
37 files changed, 4417 insertions(+), 57 deletions(-) create mode 100644
lib/lldp/aa-structs.h create mode 100644 lib/lldp/lldp-const.h create mode
100644 lib/lldp/lldp-tlv.h create mode 100644 lib/lldp/lldp.c create mode
100644 lib/lldp/lldpd-structs.c create mode 100644 lib/lldp/lldpd-structs.h
create mode 100644 lib/lldp/lldpd.c create mode 100644 lib/lldp/lldpd.h
create mode 100644 lib/ovs-lldp.c create mode 100644 lib/ovs-lldp.h create
mode 100644 tests/auto-attach.at create mode 100644 tests/test-aa.c
--
2.1.3
_______________________________________________
dev mailing list
dev@openvswitch.org
https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=AwIGaQ&c=BFpWQw8bsuKpl1SgiZH64Q&r=GATBXyTOGTB-HJaugihh79u62rJIdBqLbpVug642mjk&m=6Ka-G9MB12RH7yqVz19CEEeQ74ykwDoLfRj7oVOnUio&s=DMOiJlxZ-y1kQb79bv3fibZDJbp4f9oAXtr0_uc3LdQ&e=
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
