Looks good, thanks for the clean-up. One comment on a comment below, though.
Acked-by: Jarno Rajahalme <jrajaha...@nicira.com>
> On Mar 2, 2015, at 10:51 AM, Pravin B Shelar <pshe...@nicira.com> wrote:
>
> diff --git a/lib/ofpbuf.h b/lib/ofpbuf.h
> index 7aed44e..938b605 100644
> --- a/lib/ofpbuf.h
> +++ b/lib/ofpbuf.h
> @@ -22,7 +22,6 @@
> #include "list.h"
> #include "packets.h"
> #include "util.h"
> -#include "netdev-dpdk.h"
>
> #ifdef __cplusplus
> extern "C" {
> @@ -32,22 +31,15 @@ enum OVS_PACKED_ENUM ofpbuf_source {
> OFPBUF_MALLOC, /* Obtained via malloc(). */
> OFPBUF_STACK, /* Un-movable stack space or static buffer. */
> OFPBUF_STUB, /* Starts on stack, may expand into heap. */
> - OFPBUF_DPDK, /* buffer data is from DPDK allocated memory.
> - ref to build_ofpbuf() in netdev-dpdk. */
> };
>
> /* Buffer for holding arbitrary data. An ofpbuf is automatically reallocated
> * as necessary if it grows too large for the available memory.
> *
> - * 'frame' and offset conventions:
> - *
> - * Network frames (aka "packets"): 'frame' MUST be set to the start of the
> - * packet, layer offsets MAY be set as appropriate for the packet.
> - * Additionally, we assume in many places that the 'frame' and 'data' are
> - * the same for packets.
> + * 'frame' and 'msg' conventions:
As you renamed ‘frame’ as ‘header’, the comments should be updated as well.
> *
> * OpenFlow messages: 'frame' points to the start of the OpenFlow
Here too.
> - * header, while 'l3_ofs' is the length of the OpenFlow header.
> + * header, while 'msg' is the OpenFlow msg bofy.
> * When parsing, the 'data' will move past these, as data is being
> * pulled from the OpenFlow message.
> *
> @@ -57,65 +49,24 @@ enum OVS_PACKED_ENUM ofpbuf_source {
> * rconn: Reuses 'frame' as a private pointer while queuing.
Ditto.
> */
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
