> On Mar 3, 2015, at 3:45 AM, Kavanagh, Mark B <[email protected]> > wrote: > >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >> index 54bad02..70ef97b 100644 >> --- a/lib/dpif-netdev.c >> +++ b/lib/dpif-netdev.c >> @@ -33,6 +33,7 @@ >> >> #include "cmap.h" >> #include "csum.h" >> +#include "dp-packet.h" >> #include "dpif.h" >> #include "dpif-provider.h" > > Is there a specific reason why the 'dp' prefix is used in some files, and > 'dpif' in others? > If not, consider changing the 'dpif' prefix to 'dp', for consistency and > coherency.
‘dpif’ refers to “data path interface” - the common API to all OVS data paths. Since the new ‘dp_packet’ is visible through this interface, it could be named as ‘dpif_packet’ as well. I’m fine with ‘dp_packet’ as well, though, as it carries the connotation that ‘dp_packet’ is not defined just for the sake of the interface, but is used internally by the (userspace) datapath as well. Jarno _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
