>On Thu, Mar 5, 2015 at 1:29 AM, Panu Matilainen <[email protected]> wrote: >> RSS offload types were unified and simplified in DPDK 2.0, easily >> handled with an ifdef though. >> >OVS does not support DPDK 2.0 yet. Is there any reason to introduce >the change at this point? > DPDK 2.0 is still in development, and the final version won't be available until the end of March. As the code base is subject to change until that point, IMO, we should hold off on upstreaming 2.0 support patches until the final version is available.
>> Signed-off-by: Panu Matilainen <[email protected]> >> --- >> lib/netdev-dpdk.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >> index 1ba8310..b095826 100644 >> --- a/lib/netdev-dpdk.c >> +++ b/lib/netdev-dpdk.c >> @@ -97,8 +97,12 @@ static const struct rte_eth_conf port_conf = { >> .rx_adv_conf = { >> .rss_conf = { >> .rss_key = NULL, >> +#ifdef ETH_RSS_IPV4_TCP /* dpdk < 2.0 */ >> .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6 >> | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | >> ETH_RSS_IPV6_UDP, >> +#else >> + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP, >> +#endif >> }, >> }, >> .txmode = { >> -- >> 2.1.0 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> http://openvswitch.org/mailman/listinfo/dev >_______________________________________________ >dev mailing list >[email protected] >http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
