On Tue, Mar 17, 2015 at 03:25:36PM -0700, Ben Pfaff wrote: > On Mon, Mar 09, 2015 at 10:11:02AM +0900, Simon Horman wrote: > > NTR selection method > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > Thank you for the patch! > > Since a mask is not allowed, I would expect parse_select_group_field() > to call mf_parse_value() rather than mf_parse().
Thanks, I will update parse_select_group_field()() as you suggest. > I think that the documentation should mention that these new features > are only available in OVS 2.4 and up and only with OpenFlow 1.5 and > up and use a Netronome extension to OpenFlow. Sure, how about the following squashed into this patch? diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 88cdcbd..b11ff95 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofctl.8.in @@ -2254,12 +2254,20 @@ This is a string of 1 to 15 bytes in length known to lower layers. This field is optional for \fBadd\-group\fR, \fBadd\-groups\fR and \fBmod\-group\fR commands on groups of type \fBselect\fR. Prohibited otherwise. The default value is the empty string. +.IP +This option will use a Netronome OpenFlow extension which is only supported +when using Open vSwitch 2.4 and later with OpenFlow 1.5 and later. + .IP \fBselection_method_param\fR=\fIparam\fR 64-bit integer parameter to the selection method selected by the \fBselection_method\fR field. The parameter's use is defined by the lower-layer that implements the \fBselection_method\fR. It is optional if the \fBselection_method\fR field is specified as a non-empty string. Prohibited otherwise. The default value is zero. +.IP +This option will use a Netronome OpenFlow extension which is only supported +when using Open vSwitch 2.4 and later with OpenFlow 1.5 and later. + .IP \fBfields\fR=\fIparam\fR The field parameters to selection method selected by the \fBselection_method\fR field. The syntax is described in \fBFlow Syntax\fR @@ -2270,6 +2278,9 @@ output to the group. The use of the fields is defined by the lower-layer that implements the \fBselection_method\fR. They are optional if the \fBselection_method\fR field is specified as a non-empty string. Prohibited otherwise. The default is no fields. +.IP +This option will use a Netronome OpenFlow extension which is only supported +when using Open vSwitch 2.4 and later with OpenFlow 1.5 and later. .IP \fBbucket\fR=\fIbucket_parameters\fR The \fBadd-group\fR, \fBadd-groups\fR and \fBmod-group\fR commands > > > > > > In parse_ofp_group_mod_str__(), I think that '0' here should be either > 0 or '\0': > + memset(gm->props.selection_method, '0', > + NTR_MAX_SELECTION_METHOD_LEN); Thanks, I will go and find a brown paper bag. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
