On 04/24/2015 06:34 PM, Ben Pfaff wrote: > When packets travel among nodes in OVN over tunnels, a tunnel key value is > needed to convey the logical port to which the packet is destined. This > commit adds a tunnel_key column to the Bindings table and adds code to > ovn-northd to assign a unique tunnel_key value to each logical port. > > Signed-off-by: Ben Pfaff <blp at nicira.com> > --- > ovn/northd/ovn-northd.c | 78 > ++++++++++++++++++++++++++++++++++------------- > ovn/ovn-sb.ovsschema | 6 +++- > ovn/ovn-sb.xml | 4 +++ > 3 files changed, 66 insertions(+), 22 deletions(-)
The code here looks correct and I also tested it. I was just wondering if you could comment on the choice of a 16 bit integer here instead of a UUID. My guess is that it has to do with where this ID will be used in a tunnel protocol, but it might be nice to capture that somewhere. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
