Hi Nithin, I agree with you. We can drop this patch then.
Sorin -----Original Message----- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Thursday, 14 May, 2015 18:24 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 5/5] datapath-windows: Multiple NBLs support for VXLAN packets > On Apr 24, 2015, at 3:03 AM, Sorin Vinturis > <svintu...@cloudbasesolutions.com> wrote: > > Added support for handling multiple NBLs with only one NB when > encapsulating VXLAN packets. > > Signed-off-by: Sorin Vinturis <svintu...@cloudbasesolutions.com> hi Sorin, Was this patch necessary? Here’s my reasoning for the question. If a NBL contains an NB that cannot fit within an MTU, then the packet gets chopped up into multiple packets and the encap header added to it. If the original NBL needed to be chopped up due to software TSO, then they’d be put into multiple NBs but within the same NBL. The reason we don’t need to create multiple NBLs is that, all the NBs would evaluate to the same flow key. There’s no need to split them into multiple NBLs and process them one at a time. Pls. let me know if you disagree with this. thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
