On Wed, May 20, 2015 at 5:06 PM, Ethan Jackson <et...@nicira.com> wrote:
> When executing actions, it's possible a recirculation will occur
> causing dp_netdev_input() to be called multiple times.  If the batch
> pointers embedded in dp_netdev_flow aren't cleared, it's possible
> packets after the recirculation will be reinserted into a batch
> associated with the original lookup.  This could be very bad.
>
> This patch fixes the problem by zeroing out flow batch pointers before
> calling packet_batch_execute().  This probably has a slightly negative
> performance impact, though I haven't tried it.
>
> Signed-off-by: Ethan Jackson <et...@nicira.com>

Good catch.
Looks good to me too.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to