On Thu, Apr 09, 2015 at 06:40:25PM -0700, Andy Zhou wrote: > Signed-off-by: Andy Zhou <az...@nicira.com> > Acked-by: Ben Pfaff <b...@nicira.com> > > ---- > v1->v2: maintain ovsdb_monitor_changes using hmap instead of linked > list. > > v2->v3: no change
The comment here in struct ovsdb_monitor_table talks about 'unflushed_transaction' but the member in 'struct ovsdb_monitor_row' is just named 'transaction': /* Contains a set of 'ovsdb_monitor_changes'. Each 'changes' * tracks updates of rows with a a different 'unflushed_transaction'. */ struct hmap changes; I'd consider changing the comment to just: /* Contains 'struct ovsdb_monitor_changes' indexed by 'transaction'. */ which makes it clear that the 'transaction' member is what one needs to find the right ovsdb_monitor_changes. Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev