On Mon, May 18, 2015 at 04:10:20PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
I see some opportunity for simplification in modify_flows_check__():
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 5c8b1a5..cb53245 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -4489,13 +4489,8 @@ modify_flow_check__(struct ofproto *ofproto, struct
ofputil_flow_mod *fm,
OVS_REQUIRES(ofproto_mutex)
{
if (ofproto->ofproto_class->rule_premodify_actions) {
- enum ofperr error;
-
- error = ofproto->ofproto_class->rule_premodify_actions(
+ return ofproto->ofproto_class->rule_premodify_actions(
rule, fm->ofpacts, fm->ofpacts_len);
- if (error) {
- return error;
- }
}
return 0;
The goal here isn't obvious but maybe I'll understand later.
Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
