On Fri, Jun 05, 2015 at 12:55:41PM -0700, Jarno Rajahalme wrote: > > > On May 29, 2015, at 8:58 PM, Ben Pfaff <b...@nicira.com> wrote: > > I'm a little surprised to see the new "error_reporter" callback > > function. Can you explain a little? > > Within a bundle we are now streaming the flow mods without waiting for > a response after each flow mod, so error responses to earlier mods may > arrive any time before the closing bundle control transaction. As > there is no uniform way the users may wish to handle errors, this new > callback allows the caller to do what they want. ovs-ofctl prints the > error messages to stderr, some other callers may want to log them > instead.
OK. I'll give this a re-read and re-think for v3. > > In parse_ofp_str__(), I suspect that the "strict" versions won't ever be > > matched, because the shorter non-strict versions will be matched > > earlier. > > > > Actually, with strncmp() with the length of the token in the string, > it is the reverse! The shorter non-strict version will not match a > longer keyword, but if the order of the comparisons was changed, the > longer strict version would match the shorter non-strict version in > the string. (I tried this both ways.) I missed that the length argument to strncmp() was the length of the string that varies, not of the one that is a literal argument. Interesting--thanks. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
