Sorry for missing this discussion, Yeah, this is the correct fix. I think I must have put it there since I wanted my own display to be sorted... But I should really do it in my own .bashrc.
Will apply the patch soon, Acked-by: Alex Wang <[email protected]> Thanks, Alex Wang, On Sun, Jun 7, 2015 at 11:16 AM, Ben Pfaff <[email protected]> wrote: > [adding Alex, the author of the script] > > On Thu, May 28, 2015 at 10:57:42AM -0300, Flavio Leitner wrote: > > On Thu, May 28, 2015 at 12:07:14PM +0800, Zang MingJie wrote: > > > Signed-off-by: Zang MingJie <[email protected]> > > > --- > > > utilities/ovs-appctl-bashcomp.bash | 5 +---- > > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > > > diff --git a/utilities/ovs-appctl-bashcomp.bash > b/utilities/ovs-appctl-bashcomp.bash > > > index 67a268e..f7fb830 100755 > > > --- a/utilities/ovs-appctl-bashcomp.bash > > > +++ b/utilities/ovs-appctl-bashcomp.bash > > > @@ -598,9 +598,6 @@ _ovs_command_complete() { > > > return 0 > > > } > > > > > > -# Needed for the sorting of completions in display. > > > -export LC_ALL=C > > > - > > > > This changes only during the execution of the script which is > > needed to make sure all commands provide the expected outputs. > > Are you seeing any issue because of that? > > I'm pretty sure that the script in question is meant to be sourced into > a bash session, which would mean that it does change the active locale. > Alex, is that correct? And is this the correct fix? > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
