> On Jun 12, 2015, at 5:27 AM, Sorin Vinturis > <svintu...@cloudbasesolutions.com> wrote: > > Nithin, > > The previous patch you are referring was one of a series I had pushed when > working at the "Multiple NBLs" issue. At that time I had some trouble when > generating packets large enough for the a NBL with multiple NBs to be > generated. Because Eitan and Ankur, that also worked on this issue, pushed me > to commit my changes so they can see how things were handled, I committed the > patch series without thoroughly testing it.
Yes, I understand the cumbersome situation that dealing with multiple patches causes and I thought that was the reason too :) It is not like this happens each time, so it is ok :) My takeaway would be that we should be running a short list of pre-checkin tests before sending out the code for review. We had written it up internally here. I’ll send that out. That might be helpful. > The current patch solves a bug I have found when managing to generate large > enough packets. I hope this satisfies your curiosity. Of course, thanks for the explanation. This is one off case, not a problem as such. The only reason for my comment is that, I take patches by face-value and trust that the developer has done all the due diligence. Sometimes we miss something, and it is perfectly ok to say “I missed this, and fixing it now”, no big deal :) thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
