I would rather leave them the way they are until we fix the actual problem (disable from userspace, treat the dpif_probe_feature correctly)
Thanks, Alin. -----Mesaj original----- De la: dev [mailto:[email protected]] În numele Nithin Raju Trimis: Friday, June 19, 2015 7:02 AM Către: [email protected] Subiect: [ovs-dev] [PATCH] datapath-windows: demote some logs in flow validation These logs were being logged very frequently on the debugger. Signed-off-by: Nithin Raju <[email protected]> --- datapath-windows/ovsext/Flow.c | 2 +- datapath-windows/ovsext/Netlink/Netlink.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index 6fa10a3..194032b 100644 --- a/datapath-windows/ovsext/Flow.c +++ b/datapath-windows/ovsext/Flow.c @@ -274,7 +274,7 @@ OvsFlowNlCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx, if ((NlAttrParse(nlMsgHdr, attrOffset, NlMsgAttrsLen(nlMsgHdr), nlFlowPolicy, nlAttrs, ARRAY_SIZE(nlAttrs))) != TRUE) { - OVS_LOG_ERROR("Attr Parsing failed for msg: %p", + OVS_LOG_LOUD("Attr Parsing failed for msg: %p", nlMsgHdr); rc = STATUS_INVALID_PARAMETER; goto done; diff --git a/datapath-windows/ovsext/Netlink/Netlink.c b/datapath-windows/ovsext/Netlink/Netlink.c index a62d760..e730bed 100644 --- a/datapath-windows/ovsext/Netlink/Netlink.c +++ b/datapath-windows/ovsext/Netlink/Netlink.c @@ -1097,7 +1097,7 @@ NlAttrParse(const PNL_MSG_HDR nlMsg, UINT32 attrOffset, for (iter = 0; iter < n_attrs; iter++) { const PNL_POLICY e = (const PNL_POLICY)(&policy[iter]); if (!e->optional && e->type != NL_A_NO_ATTR && !attrs[iter]) { - OVS_LOG_ERROR("Required attr:%d missing", iter); + OVS_LOG_LOUD("Required attr:%d missing", iter); goto done; } } -- 1.8.5.6 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
