How about the following:

Before running the unit tests make sure to add the pthread libraries to your
PATH environment variable.

One of the unit tests starts Open vSwitch as a system wide service. This
test expects the pthread libraries path to be in the Windows' SYSTEM PATH
environment variable. If while running unit tests, you do not have the
permissions to start a system wide service or if you already have a Open vSwitch
service running, you can disable the unit test
with: make check TESTSUITEFLAGS="-k \!windows-service –j8”

Alin.

-----Mesaj original-----
De la: Gurucharan Shetty [mailto:shet...@nicira.com] 
Trimis: Tuesday, June 23, 2015 5:51 PM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH 3/3] Update windows test documentation

On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean <aserd...@cloudbasesolutions.com> 
wrote:
> Describe explictly where to add the pthread library to the PATH variable.
>
> In case the pthread library directory was added to the user PATH 
> variable the service failed to start.
>
> Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com>
> ---
>  INSTALL.Windows.md | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md index 
> 6d870ed..52acf6e 100644
> --- a/INSTALL.Windows.md
> +++ b/INSTALL.Windows.md
> @@ -92,6 +92,9 @@ or from a distribution tar ball.
>
>      % make check TESTSUITEFLAGS="-j8"
>
> +  For "daemon --service" test make sure to have the pthread libaries 
> + in  the the Windows' SYSTEM PATH environment variable
> +
How about the following wording instead?
(One of the unit tests starts Open vSwitch as a system wide service. This
  test expects the pthread libraries path to be in the Windows' SYSTEM PATH
  environment variable. If while running unit tests, you do not have the
  permissions to start a system wide service or if you already have a Open 
vSwitch
  service running, you can disable the unit test
  with: make check TESTSUITEFLAGS="-k \!windows-service –j8”)

If you think above is correct, I will update your patch before committing.

>  * To install all the compiled executables on the local machine, run:
>
>      % make install
> --
> 1.9.5.msysgit.0
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to