> nitpick, could we move this deletion to next commit?
Make sense. I moved it.
>
>
> Acked-by: Alex Wang <al...@nicira.com>
>
Thanks for the review. Pushed to master.
>
>
>>
>> /* ctl_fatal() also logs the error, so it is preferred in this file. */
>> @@ -250,9 +247,8 @@ struct ctl_table_class {
>> * entry. */
>> extern const struct ctl_table_class tables[];
>>
>> -const struct ctl_table_class *get_table(const char *table_name);
>> -void set_column(const struct ctl_table_class *,
>> - const struct ovsdb_idl_row *, const char *arg,
>> - struct ovsdb_symbol_table *);
>> +void ctl_set_column(const char *table_name,
>> + const struct ovsdb_idl_row *, const char *arg,
>> + struct ovsdb_symbol_table *);
>>
>> #endif /* db-ctl-base.h */
>> diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
>> index c9af355..863bc73 100644
>> --- a/utilities/ovs-vsctl.c
>> +++ b/utilities/ovs-vsctl.c
>> @@ -1556,8 +1556,8 @@ add_port(struct ctl_context *ctx,
>> }
>>
>> for (i = 0; i < n_settings; i++) {
>> - set_column(get_table("Port"), &port->header_, settings[i],
>> - ctx->symtab);
>> + ctl_set_column("Port", &port->header_, settings[i],
>> + ctx->symtab);
>> }
>>
>> bridge_insert_port((bridge->parent ? bridge->parent->br_cfg
>> --
>> 1.9.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
