On Mon, Jul 13, 2015 at 08:23:45AM -0700, Ben Pfaff wrote: > On Mon, Jul 13, 2015 at 04:19:46PM +0530, Saloni Jain wrote: > > 2. ovs-ofctl -O Openflow14 mod-table <br> <table_id> vacancy-<low..high> > > -- To be implemented > > OFPTC14_VACANCY_EVENTS is the only set table-mod config property and > > eviction if configured previously will get unset. > > I don't think it's good for mod-table to affect properties that the user > didn't request. I suggest that "ovs-ofctl table-mod" should, when > necessary, first use an OFPMP_TABLE_DESC request to obtain the current > configuration, then modify it according to the user's request.
Actually, let me take that back. I think that OFPTC14_VACANCY_EVENTS should be implemented on a per-OpenFlow connection basis. That is, if a controller turns on OFPTC14_VACANCY_EVENTS, then this should affect its connection only; no other connections should receive the vacancy events. That makes more sense to me than to have an ovs-ofctl call affect all subsequent OpenFlow connections (in either direction), because a given controller is the only entity that knows whether it wants to receive vacancy events. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
