Awesome work. I plan to do a more in depth review but I had a quick
comment about something I thought of last night.
On 07/13/2015 11:22 PM, Alex Wang wrote:
> This commit adds the gateway module to ovn-controller-vtep. The
> module will register the physical switches to ovnsb as chassis and
> constantly update the "logical_switches" column in Chassis table.
>
> Limitation:
>
> - Do not support reading multiple tunnel ips of physical switch.
>
> Signed-off-by: Alex Wang <al...@nicira.com>
> + /* If not already in 'lswitches', adds the logical switch
> + * to logical port map. The logical port is defined as
> + * {pswitch->name}_{ls->name}. */
> + if (!smap_get(&lswitches, ls->name)) {
> + char *lport = xasprintf("%s_%s", pswitch->name,
> ls->name);
> +
> + smap_add(&lswitches, ls->name, lport);
I'm going to need a way to make sure that an OpenStack Neutron end user
is not able to create ports with a name that could interfere with
special port names. I'm going to need special port names for the
Neutron provider networks thing I'm working on, too.
A simple solution would be to adopt a convention where we prefix all
special port names with "ovn_". The Neutron driver could just reject
any port names specified by users with that prefix and only use that for
ports created automatically for a special purpose.
I suppose a cleaner solution would be to avoid having any special port
names, but I'm happy to just consider that something we may do later.
What do you think?
--
Russell Bryant
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
