On Tue, Jul 14, 2015 at 10:09:41PM -0400, Aaron Conole wrote: > For some time, it seems that the distcheck make target has not functioned > properly. This patch works around the automake imposed distcheck read-only > directory, as well as signaling to travis-ci that sudo is required (which is > required for new github forks as of 2015-01-01). > > Tested on travis-ci, and on a ubuntu 14.04LTS system. > --- > NOTE: This is a re-submission because it seems my email configuration was not > correct. I hope this gets through. > > Signed-off-by: Aaron Conole <aa...@bytheb.org>
Thanks for the contribution! I have some questions. Can you explain the following change? What effect does it have, and why is it needed only in one fork of the "if"? > --- a/Makefile.am > +++ b/Makefile.am > @@ -44,7 +44,7 @@ endif > if WIN32 > psep=";" > else > -psep=":" > +psep=: > endif > # PYTHONDONTWRITEBYTECODE=yes keeps Python from creating .pyc and .pyo > # files. Creating .py[co] works OK for any given version of Open In the two cases where this patch "chmod"s source directories so that header files can be generated, I think it would be better to generate the header files in build directories instead. I don't understand why this adds ofp-errors.c and ofp-msgs.c to EXTRA_DIST. These files should be distributed already because they are in lib_libopenvswitch_la_SOURCES. I don't understand the following change, can you explain? > .ovsidl.c: > - $(AM_V_GEN)$(OVSDB_IDLC) c-idl-source $< > $@.tmp && mv $@.tmp $@ > + $(AM_V_GEN)$(OVSDB_IDLC) c-idl-source $< > $@.tmp && mv -f $@.tmp $@ > .ovsidl.h: > - $(AM_V_GEN)$(OVSDB_IDLC) c-idl-header $< > $@.tmp && mv $@.tmp $@ > + $(AM_V_GEN)$(OVSDB_IDLC) c-idl-header $< > $@.tmp && mv -f $@.tmp $@ > > BUILT_SOURCES += $(OVSIDL_BUILT) Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
