On Tue, Sep 8, 2015 at 2:11 PM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Aug 31, 2015 at 07:57:06PM -0700, Jesse Gross wrote: >> In cases where we don't have a map of tunnel metadata options (such >> as with ovs-ofctl) we dynamically allocate them as part of the match. >> However, dynamic allocation brings the possibility of errors such as >> duplicate entries or running out of space. Up until now, anything that >> would cause an error was silently ignored. Since that is not very user >> friendly, this adds a mechanism for reporting these types of errors. >> >> Signed-off-by: Jesse Gross <je...@nicira.com> > > Some of the functions that take an err_str parameter don't set it to > NULL initially, e.g. at least tun_metadata_set_match(), > metadata_loc_from_match().
This was semi-intentional the sense that their calling functions already do this. However, it's probably not the most robust thing to do, so I added an explicit initialization. > Is it possible to add some tests that provoke these messages? It's a good idea, I added a couple of tests. > Acked-by: Ben Pfaff <b...@nicira.com> Thanks, I changed the pieces that I mentioned and applied this series to master. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
