Hi Ben, I noticed that the "mac" field of Logical_Router_Port must be set the same as mac address in "addresses" field of the peer patch port in Logical_Port table. At least this is what has been verified in my test setup and also in ovn.at test cases.
If this is a constraint I wonder if it is better to ensure in schema, e.g. removing the mac field in Logical_Router_Port table, and always use mac information from its peer lswitch patch port when needed. I'd like to propose a patch for this. While working on the code, I realized that this might be for the case of peering lrouter ports. In that case, however, mac is not really needed because no ARP would be sent between peering lrouter ports. Please correct me if I am wrong. If for any reason this field is required and must be set the same as peering lswitch patch port, should this be documented somewhere to avoid confusion? Another question related to the patch port is, in Logical_Port the key is name, while in Logical_Router_Port the key is uuid, which indicates the router-option in peer lswitch patch port must be set with uuid rather than name. Is there any special considerations? If not, could you review my patch for this (tests passed): http://openvswitch.org/pipermail/dev/2015-November/061961.html Thanks, Han _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
