On Tue, Nov 24, 2015 at 03:28:35PM -0500, Aaron Conole wrote:
> Commit 3544358aa596 ("datapath: Improve kernel hash table") removed the
> failure condition of ovs_vport_del by switching away from a custom
> hashtable which allocated a new bucket, to an hlist with flexible-array
> buckets. The function stopped returning failure code at that point, so
> remove the misleading comment.
>
> Signed-off-by: Aaron Conole <acon...@redhat.com>
> ---
> datapath/vport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/datapath/vport.c b/datapath/vport.c
> index 024491f..e000e8c 100644
> --- a/datapath/vport.c
> +++ b/datapath/vport.c
> @@ -266,8 +266,8 @@ int ovs_vport_set_options(struct vport *vport, struct
> nlattr *options)
> *
> * @vport: vport to delete.
> *
> - * Detaches @vport from its datapath and destroys it. It is possible to fail
> - * for reasons such as lack of memory. ovs_mutex must be held.
> + * Detaches @vport from its datapath and destroys it. ovs_mutex must be
> + * held.
> */
> void ovs_vport_del(struct vport *vport)
> {
> --
> 2.6.1.133.gf5b6079
Acked-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
