> On Dec 15, 2015, at 12:28 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Dec 14, 2015 at 05:23:36PM -0800, Daniele Di Proietto wrote: >> In the ODP context an empty mask netlink attribute usually means that >> the flow should be an exact match. >> >> odp_flow_key_to_mask() instead returns a struct flow_wildcards >> with matches only on recirc_id and vlan_tci. >> >> A more appropriate behavior is to handle a missing (zero length) netlink >> mask specially (like we do in userspace and Linux datapath) and create >> an exact match flow_wildcards from the original flow. >> >> This fixes a bug in revalidate_ukey(): every flow created with >> megaflows disabled would be revalidated away, because the mask would >> seem too generic. (Another possible fix would be to handle the special >> case of a missing mask in revalidate_ukey(), but this seems a more >> generic solution). >> >> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> >> Acked-by: Jarno Rajahalme <jrajaha...@nicira.com> > > Given that Jarno acked this, are you looking for more reviews? Or were > there significant changes needed for backporting?
Jarno acked the original series, and Daniele cherry-picked them all. This one wasn't trivial, though, so he wanted another set of eyes on this backport to 2.3. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
