On Tue, 12 Jan 2016 09:23:12 +0300
Ilya Maximets <[email protected]> wrote:
> On 12.01.2016 07:13, Ben Pfaff wrote:
> > On Mon, Jan 11, 2016 at 06:24:10PM -0800, Joe Stringer wrote:
> >> DPDK build was broken after commit 2f8932e8403a ("poll: Suppress
> >> logging for pmd threads.") due to the following error:
> >>
> >> lib/netdev-dpdk.c:245:13: error: static declaration of
> >> ‘thread_is_pmd’ follows non-static declaration
> >> lib/ovs-thread.h:526:6: note: previous declaration of
> >> ‘thread_is_pmd’ was here
> >>
> >> Reported-at: https://travis-ci.org/openvswitch/ovs/jobs/101648756
> >> Fixes: 2f8932e8403a ("poll: Suppress logging for pmd threads.")
> >> CC: Ilya Maximets <[email protected]>
> >> Signed-off-by: Joe Stringer <[email protected]>
> >
> > Sorry about that. As long as you've tested it:
> >
> > Acked-by: Ben Pfaff <[email protected]>
>
> Thanks for patch.
> Only one comment: I am afraid that the replacement of function can
> slow down the dpdk_do_tx_copy. What do you think?
Can we rename thread_is_pmd to dpdk_thread_is_pmd() or something
like that instead?
Thanks
fbl
>
> Best regards, Ilya Maximets.
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
--
fbl
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
