We pull off the features to get at the port descriptors that follow them
(which we pull in port_iterator_next()).
On Thu, Jan 21, 2016 at 08:19:26AM -0800, William Tu wrote:
> Hi Ben,
>
> in port_iterator_fetch_features, why do we need to decode/pull the feature
> but later on never use it at all?
>
> Thanks
> William
>
> @@ -865,8 +864,7 @@ port_iterator_fetch_features(struct port_iterator *pi)
>
> > }
> >
> > struct ofputil_switch_features features;
> > - enum ofperr error = ofputil_decode_switch_features(oh, &features,
> > - pi->reply);
> > + enum ofperr error = ofputil_pull_switch_features(pi->reply,
> > &features);
> > if (error) {
> > ovs_fatal(0, "%s: failed to decode features reply (%s)",
> > vconn_get_name(pi->vconn), ofperr_to_string(error));
> > --
> > 2.1.3
> >
> >
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
