On 01/28/2016 10:45 AM, Thomas F Herbert wrote:
> On 1/28/16 9:54 AM, Russell Bryant wrote:
>> On 01/28/2016 08:48 AM, Thomas F Herbert wrote:
>>> In the process of building RPM's in OVS-OPNFV project, it was
>>> discovered that the
>>> Rhel spec file for building the kernel module RPM was broken in such
>>> a way to break
>>> depmod on kernel module installs.
>>>
>>> This fixes the spec file be deleting the reference to openvswitch.conf.
>>>
>>> Tested on Centos 7
>> The text here seems like it would be useful for the commit message.
>>
>> I'm also pretty confused about the spec files and which ones are used
>> where.  While possibly unrelated to this patch, it would be really nice
>> if we could clear this up in some documentation.
>>
>> We have:
>>
>>      openvswitch.spec
>>      openvswitch-kmod-rhel6.spec
> Russel, thanks for your comments. This spec file is for building the
> kernel module and it is broken. The other spec files as far as I know
> may be poorly documented but they at least work as far as I know. This
> patch addresses the limited case of fixing a broken spec file. I think
> we should fix this broken behavior first and address the larger issues
> of documentation, revisions of distros etc. with a broader
> patch/discussion.

I understand, but you're hitting a problem on CentOS 7 using a spec
intended for CentOS 6 as far as I can tell.  That's why we need to sort
out if that's even an intended/valid use of this spec.

Also see Guru's comment noting that this patch reverts a previous fix
for this package on CentOS 6.

-- 
Russell Bryant
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to