On Fri, 29 Jan 2016 14:40:11 -0500 Russell Bryant <russ...@ovn.org> wrote:
> On 01/29/2016 02:34 PM, Thomas F Herbert wrote: > > > > > > On 1/29/16 12:43 PM, Russell Bryant wrote: > >> On 01/29/2016 12:04 PM, Thomas F Herbert wrote: > >>> > >>> On 1/28/16 3:46 PM, Russell Bryant wrote: > >>>> On 01/28/2016 02:55 PM, Russell Bryant wrote: > >>>>> On 01/28/2016 12:56 PM, Guru Shetty wrote: > >>>>>> On 28 January 2016 at 08:46, Russell Bryant <russ...@ovn.org > >>>>>> <mailto:russ...@ovn.org>> wrote: > >>>>>> > >>>>>> The rpm build instructions did not clarify what spec > >>>>>> files were to be > >>>>>> used for RHEL 7 and its derivatives. Clarify that you're > >>>>>> actually > >>>>>> supposed to use the spec files called "fedora" for RHEL > >>>>>> 7 right now. > >>>>>> > >>>>>> Update references to Fedora versions to reflect the > >>>>>> current release > >>>>>> (23), as neither 16 or 17 are supported releases anymore. > >>>>>> > >>>>>> Signed-off-by: Russell Bryant <russ...@ovn.org > >>>>>> <mailto:russ...@ovn.org>> > >>>>>> > >>>>>> > >>>>>> I think openvswitch-kmod-fedora has been an orphan for a long > >>>>>> time. I think that is because the users in fedora get a more > >>>>>> upto date kernel module from Linux kernel itself. It probably > >>>>>> still builds, but it will > >>>>>> likely not be picked up with modprobe because there is till the > >>>>>> native > >>>>>> kernel module. > >>>>> It seems worth keeping for testing WIP features, at least. > >>>>> > >>>>> It doesn't build for me, though. The error I get is that it's > >>>>> trying to > >>>>> create a directory outside of the $RPM_BUILD_ROOT during "make > >>>>> modules_install". > >>>>> > >>>>> I'm building using: > >>>>> > >>>>> $ rpmbuild -bb -D "kversion `uname -r`" > >>>>> rhel/openvswitch-kmod-fedora.spec > >>>>> > >>>>> ... > >>>>> > >>>>> mkdir: cannot create directory > >>>>> '/lib/modules/4.3.3-300.fc23.x86_64/extra': Permission denied > >>>>> > >>>>> > >>>>> I was looking at how to pass $RPM_BUILD_ROOT into there > >>>>> properly, but I > >>>>> got distracted before I got it to work. > >>>>> > >>>> I just posted another patch which makes it build on Fedora 23 for > >>>> me, at > >>>> least. > >>> Kmod builds and installs perfectly on Centos7 using Fedora spec > >>> without patch. > >> How did you build it? Did you run rpmbuild directly? If so, did > >> you run it as root? > >> > >> Running rpmbuild as root with the current spec will install the > >> kernel modules into your system's /lib/modules/ directory as a > >> part of the rpm build. That's what broke for me (since I wasn't > >> root). > > I don't understand. Running rpmbuild will build the rpm and that > > can be done without root. Doing a rpm -i on the resultant rpm will > > require root. I think your problem is that you didn't specify a > > local top dir so it is using the default which is where it is > > planning to do the installation. > > > > Here is my script, cloned from ovs-opnfv because it is currently > > under review and not merged yet. > > > > https://github.com/tfherbert/ovs_nfv/blob/master/build/build_ovs_rpm.sh > > You're right, I didn't specify a _topdir. If that's required, our > docs need that added, as well. It shouldn't be required, but you can customize. The documentation mentions how to double check _topdir: rpm --eval '%{_topdir}' But that has nothing to do with make modules_install because that is a kernel's Makefile target and it does try to install in the / by default. The rpm will continue building the package even with those permission errors from modules_install but the ``find´´ command later in the spec "fixes" it by installing from the source tree to the $RPM_BUILD_ROOT. -- fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev