On Thu, Feb 11, 2016 at 12:24:43PM +0530, niti1...@gmail.com wrote: > From: Niti Rohilla <niti.rohi...@tcs.com> > > "ovs-ofctl set-first-egress-table <SWITCH> <table_id>" can be used to set > first egress > table. > This patch enhances TABLE_FEATURES_REQUEST message to set the first egress > table and > TABLE_FEATURES_REPLY to identify the table which is configured as first > egress table. > > Signed-off-by: Niti Rohilla <niti.rohi...@tcs.com>
There's a major problem here: it stores the first egress table in a global variable, in function ofputil_egress_table_id(). That's not acceptable. It will not work properly when there is more than one bridge. The function ofpact_put_ofp15_write_actions() has a comment that doesn't describe what it actually does, and it can be better written as just f->nonmiss.write.ofpacts &= ~((UINT64_C(1) << OFPACT_OUTPUT) | (UINT64_C(1) << OFPACT_GROUP)); _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev