Thanks for taking a look, I will send an updated patch in the afternoon. On Tue, Feb 23, 2016 at 10:02 AM, Justin Pettit <jpet...@ovn.org> wrote:
> > > On Feb 22, 2016, at 4:15 PM, Dennis Sam <d...@arista.com> wrote: > > In the title, there should be a space between "vtep:" and "Add". Sure, will do. > > > @@ -251,6 +252,7 @@ Andrey Korolyov and...@xdel.ru > > Anshuman Manral anshuman.man...@outlook.com > > Anton Matsiuk anton.mats...@gmail.com > > Anup Khadka khadka...@gmail.com > > +Anupam Chanda acha...@vmware.com > > We can drop Anupam from here, since he was already listed earlier in the > section that lists code contributors. > Ah sure, sorry I didn't notice. > > > Anuprem Chalvadi achalv...@vmware.com > > Ariel Tubaltsev atubalt...@vmware.com > > Arkajit Ghosh arkajit.gh...@tcs.com > > diff --git a/vtep/vtep.xml b/vtep/vtep.xml > > index 7112111..66a26d5 100644 > > --- a/vtep/vtep.xml > > +++ b/vtep/vtep.xml > > @@ -310,6 +310,28 @@ > > requested by the NVC due to lack of resources. > > </column> > > > > + <column name="switch_fault_status" key="lr_switch_bindings_fault"> > > + Indicates that the switch has been unable to create the logical > router > > + interfaces requested by the NVC due to conflicting > configurations or a lack > > + of hardware resources. > > + </column> > > + > > + <column name="switch_fault_status" key="lr_static_routes_fault"> > > + Indicates that the switch has been unable to create the static > routes > > + requested by the NVC due to conflicting configurations or a > lack of hardware > > + resources. > > + </column> > > + > > + <column name="switch_fault_status" key="lr_creation_fault"> > > + Indicates that the switch has been unable to create the logical > router > > + requested by the NVC due to conflicting configurations or a > lack of hardware > > + resources. > > + </column> > > Some of these lines are longer than 79 characters. Can you shorten them > to fall in line with CodingStyle.md? Okay. > > > + > > + <column name="switch_fault_status" key="routing_support_fault"> > > + Indicates that the switch does not support logical routing. > > + </column> > > Is it on purpose that all the other errors start with "lr_" but this one > starts with "routing_"? It seems like "lr_support_fault" would be more > consistent. > It was intentional, but you comment is fair, it can be change it to 'lr_support_fault". > > Thanks, > > --Justin > > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
