On Thu, Mar 03, 2016 at 02:29:16PM -0800, Justin Pettit wrote:
>
> > On Feb 19, 2016, at 4:40 PM, Ben Pfaff <b...@ovn.org> wrote:
>
> > +struct mcgroup {
> > + struct hmap_node dp_name_node; /* Index by (logical datapath, name). */
> > + const struct sbrec_multicast_group *mg;
> > +};
> > +
> > +void
> > +mcgroup_index_init(struct mcgroup_index *mcgroups, struct ovsdb_idl
> > *ovnsb_idl)
> > +{
> > + hmap_init(&mcgroups->by_dp_name);
> > +
> > + const struct sbrec_multicast_group *sb;
>
> Pretty minor, but when looking at the code later in the function, I
> would have thought "sb" was a pointer to the database. I think I was
> particularly thrown because it's referred to as "mg" in the "mcgroup"
> definition.
'sb' is a pointer to a database record (any "struct sbrec_*" is a
database record), so you would have thought correctly.
What do you mean?
> Acked-by: Justin Pettit <jpet...@ovn.org>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
