> -----Original Message-----
> From: dev [mailto:[email protected]] On Behalf Of Aaron Conole
> Sent: Friday, April 1, 2016 4:32 PM
> To: [email protected]; Flavio Leitner <[email protected]>; Traynor, Kevin
> <[email protected]>; Panu Matilainen <[email protected]>;
> Wojciechowicz, RobertX <[email protected]>; Mooney, Sean K
> <[email protected]>; Andy Zhou <[email protected]>; Daniele Di Proietto
> <[email protected]>; Zoltan Kiss <[email protected]>; Christian
> Ehrhardt <[email protected]>; Ben Pfaff <[email protected]>
> Subject: [ovs-dev] [PATCH v11 3/8] netdev-dpdk: Convert initialization from
> cmdline to db
> 
> Existing DPDK integration is provided by use of command line options which
> must be split out and passed to librte in a special manner. However, this
> forces any configuration to be passed by way of a special DPDK flag, and
> interferes with ovs+dpdk packaging solutions.
> 
> This commit delays dpdk initialization until after the OVS database
> connection is established, at which point ovs initializes librte. It
> pulls all of the config data from the OVS database, and assembles a
> new argv/argc pair to be passed along.
> 
> Signed-off-by: Aaron Conole <[email protected]>
> ---

hi Aaron,

There's a few hunks in this patch that don't apply cleanly to master
anymore. It conflicts with the cleanup in d46285.


----8<---------8<-----

> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index 7d6976f..c350247 100644
> --- a/vswitchd/vswitch.xml
> +++ b/vswitchd/vswitch.xml
> @@ -171,11 +171,63 @@
>          </p>
>        </column>
> 
> +      <column name="other_config" key="n-dpdk-rxqs"
> +              type='{"type": "integer", "minInteger": 1}'>
> +        <p>
> +          Specifies the maximum number of rx queues to be created for each
> dpdk
> +          interface.  If not specified or specified to 0, one rx queue will
> +          be created for each dpdk interface by default.
> +        </p>
> +      </column>

This was removed from master - looks like it snuck back in through a rebase.

I'll give it another review and quick test when it's rebased, but with the 
issues
above addressed consider it to be acked.

Acked-by: Kevin Traynor <[email protected]>

_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to