It's a reasonable rationale. Can you add it to the commit log, please?
On Tue, Apr 12, 2016 at 07:35:34PM +0000, Rodriguez Betancourt, Esteban wrote: > By separating it in a new script, other tools can rely on this > "canonical way to calculate the cksum of a schema within this project" > (as this calculation is "implementation specific", as defined in the RFC). > > We have some tools that modify the schema/generates schema files and > each had to implement this calculation, probably in a different way > (in fact, that's how we discover that the current cksum-schema-check > was calculating a different value that our scripts). > > And last, but not least, developers that modify the schema > could find useful the script, if they wish to automate things like > cksum updating, or schema indentation. > > Thanks, > Esteban > > > > -----Original Message----- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: domingo, 10 de abril de 2016 13:27 > > To: Rodriguez Betancourt, Esteban <esteb...@hpe.com> > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] cksum: Refine schema cksum validation > > > > On Thu, Apr 07, 2016 at 10:43:20PM +0000, Rodriguez Betancourt, Esteban > > wrote: > > > Calculates the cksum removing the cksum line using a more strict regex > > > than the used previously. > > > It fixes a problem when calculating the cksum of a schema that has > > > fields with the substring cksum (e.g.: a checksum column), lines that > > > the previous cksum calculation incorrectly removes before running > > > cksum. > > > > > > Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> > > > > Why does this introduce a new script? > > > > Thanks, > > > > Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev