Paul,
If you are sure that tunKey->tunnelId will always be set, it would be a
good idea to mark .optional as FALSE in definition of
nlFlowTunnelKeyPolicy.
-- Nithin
-----Original Message-----
From: dev <dev-boun...@openvswitch.org> on behalf of Paul Boca
<pb...@cloudbasesolutions.com>
Date: Friday, April 15, 2016 at 8:04 AM
To: "dev@openvswitch.org" <dev@openvswitch.org>
Subject: [ovs-dev] [PATCH 3/3] datapath-windows: Removed always
true condition in VXLAN
>Instance ID flag must be set to 1 in case of valid VXLAN id
>
>Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com>
>---
> datapath-windows/ovsext/Vxlan.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/datapath-windows/ovsext/Vxlan.c
>b/datapath-windows/ovsext/Vxlan.c
>index b89c032..20214cb 100644
>--- a/datapath-windows/ovsext/Vxlan.c
>+++ b/datapath-windows/ovsext/Vxlan.c
>@@ -304,10 +304,8 @@ OvsDoEncapVxlan(POVS_VPORT_ENTRY vport,
> vxlanHdr->locallyReplicate = 0;
> vxlanHdr->flags2 = 0;
> vxlanHdr->reserved1 = 0;
>- if (tunKey->flags | OVS_TNL_F_KEY) {
>- vxlanHdr->vxlanID = VXLAN_TUNNELID_TO_VNI(tunKey->tunnelId);
>- vxlanHdr->instanceID = 1;
>- }
>+ vxlanHdr->vxlanID = VXLAN_TUNNELID_TO_VNI(tunKey->tunnelId);
>+ vxlanHdr->instanceID = 1;
> vxlanHdr->reserved2 = 0;
> }
> return STATUS_SUCCESS;
>--
>2.7.2.windows.1
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pN
>HQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=L790khoAaFh_SQ9evsnFC1zxBU5uiJ
>5XMRpbbvbPiII&s=GJyKbM5YwP_YPJNP_puR1CGbF_kf0nNHuTBdb6rvDGQ&e=
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
