On 26/04/2016 16:35, "Flavio Leitner" <f...@sysclose.org> wrote: >On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote: >> The function simply returns the ethernet type of the packet (after >> eventually discarding the VLAN tag). It will be used by a following >> commit. >> >> Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> >> --- > >I agree with Joe that we should avoid forcing inlining. > >Acked-by: Flavio Leitner <f...@sysclose.org> I would try to avoid forcing inlining in general, but this is done to prevent a performance regression in miniflow_extract(). Antonio spotted this out in v1 of the series: http://openvswitch.org/pipermail/dev/2016-February/065454.html If you guys agree, I'd be inclined to keep the ALWAYS_INLINE here. Thanks for the review! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
- [ovs-dev] [PATCH v2 00/15] Userspace (DPDK) connection... Daniele Di Proietto
- [ovs-dev] [PATCH v2 02/15] flow: Export parse_ipv... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 02/15] flow: Export p... Joe Stringer
- Re: [ovs-dev] [PATCH v2 02/15] flow: Expo... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 02/15] flow: Export p... Flavio Leitner
- [ovs-dev] [PATCH v2 03/15] flow: Introduce parse_... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 03/15] flow: Introduc... Joe Stringer
- Re: [ovs-dev] [PATCH v2 03/15] flow: Introduc... Flavio Leitner
- Re: [ovs-dev] [PATCH v2 03/15] flow: Intr... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 03/15] flow: ... Flavio Leitner
- [ovs-dev] [PATCH v2 07/15] conntrack: Implement f... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 07/15] conntrack: Imp... Joe Stringer
- Re: [ovs-dev] [PATCH v2 07/15] conntrack:... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 07/15] conntrack: Imp... Flavio Leitner
- [ovs-dev] [PATCH v2 10/15] dpif-netdev: Implement... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 10/15] dpif-netdev: I... Joe Stringer
- Re: [ovs-dev] [PATCH v2 10/15] dpif-netde... Daniele Di Proietto
- Re: [ovs-dev] [PATCH v2 10/15] dpif-netdev: I... Flavio Leitner
- [ovs-dev] [PATCH v2 01/15] packets: Define ICMP t... Daniele Di Proietto