On Wed, May 4, 2016 at 8:26 AM, Ryan Moats <[email protected]> wrote:
> "dev" <[email protected]> wrote on 05/03/2016 05:32:37 PM: > > > From: Darrell Ball <[email protected]> > > To: [email protected], [email protected], [email protected], > > [email protected] > > Date: 05/03/2016 05:33 PM > > Subject: [ovs-dev] [patch_v8] vtep: add source node replication support. > > Sent by: "dev" <[email protected]> > > > > > This patch series updates the vtep schema, vtep-ctl commands and vtep > > simulator to support source node replication in addition to service node > > replication per logical switch. The default replication mode is service > node > > as that was the only mode previously supported. Source node replication > > mode is optionally configurable and resetting the replication mode > implicitly > > sets the replication mode back to a default of service node. > > > > Signed-off-by: Darrell Ball <[email protected]> > > --- > > tests/vtep-ctl.at | 32 +++++++++++++++++++++++ > > vtep/README.ovs-vtep.md | 30 ++++++++++++++++++++-- > > vtep/ovs-vtep | 36 +++++++++++++++++++++++--- > > vtep/vtep-ctl.8.in | 15 +++++++++++ > > vtep/vtep-ctl.c | 61 > ++++++++++++++++++++++++++++++++++++++++++++ > > vtep/vtep.ovsschema | 9 +++++-- > > vtep/vtep.xml | 67 ++++++++++++++++++++++++++++++++++++++ > > +++++++---- > > 7 files changed, 237 insertions(+), 13 deletions(-) > > > > diff --git a/tests/vtep-ctl.at b/tests/vtep-ctl.at > > index 99e97e8..6a7e059 100644 > > --- a/tests/vtep-ctl.at > > +++ b/tests/vtep-ctl.at > > @@ -318,6 +318,38 @@ CHECK_LSWITCHES([a]) > > VTEP_CTL_CLEANUP > > AT_CLEANUP > > > > +AT_SETUP([add-ls a, set-replication-mode a source_node]) > > +AT_KEYWORDS([vtep-ctl]) > > +VTEP_CTL_SETUP > > +AT_CHECK([RUN_VTEP_CTL( > > + [add-ls a],[set-replication-mode a source_node], > > + [get-replication-mode a])], > > + [0], [source_node > > +], [], [VTEP_CTL_CLEANUP]) > > +VTEP_CTL_CLEANUP > > +AT_CLEANUP > > + > > +AT_SETUP([add-ls a, set-replication-mode a service_node]) > > +AT_KEYWORDS([vtep-ctl]) > > +VTEP_CTL_SETUP > > +AT_CHECK([RUN_VTEP_CTL( > > + [add-ls a],[set-replication-mode a service_node], > > + [get-replication-mode a])], > > + [0], [service_node > > +], [], [VTEP_CTL_CLEANUP]) > > +VTEP_CTL_CLEANUP > > +AT_CLEANUP > > + > > +AT_SETUP([add-ls a, reset-replication-mode a]) > > +AT_KEYWORDS([vtep-ctl]) > > +VTEP_CTL_SETUP > > +AT_CHECK([RUN_VTEP_CTL( > > + [add-ls a],[reset-replication-mode a], > > + [get-replication-mode a])], > > + [0], [[(null)] > > +], [], [VTEP_CTL_CLEANUP]) > > +VTEP_CTL_CLEANUP > > +AT_CLEANUP > > > > dnl > ---------------------------------------------------------------------- > > AT_BANNER([vtep-ctl unit tests -- logical binding tests]) > > diff --git a/vtep/README.ovs-vtep.md b/vtep/README.ovs-vtep.md > > index 6734dab..6d37e37 100644 > > --- a/vtep/README.ovs-vtep.md > > +++ b/vtep/README.ovs-vtep.md > > @@ -166,13 +166,39 @@ vtep-ctl bind-ls br0 p0 0 ls0 > > vtep-ctl set Logical_Switch ls0 tunnel_key=33 > > ``` > > > > -3. Direct unknown destinations out a tunnel: > > +3. Optionally, change the replication mode from a default of > service_node to > > + source_node, which can be done at the logical switch level: > > + > > + ``` > > +vtep-ctl set-replication-mode ls0 source_node > > + ``` > > + > > +The replication mode can also be reset back to the default of > > service node replication, if needed, at the logical switch level: > > + > > + ``` > > +vtep-ctl reset-replication-mode ls0 > > + ``` > > + > > +Setting the replication mode back to the default of service_node > replication > > +mode can also be done via the set command, if needed: > > + > > + ``` > > +vtep-ctl set-replication-mode ls0 service_node > > + ``` > > + > > +The replication mode can also be queried using the command: > > + > > + ``` > > +vtep-ctl get-replication-mode ls0 > > + ``` > > + > > +4. Direct unknown destinations out a tunnel: > > Please include a description of the difference between the two replication > modes here (I know there is a comment in the code and text in the vtep.xml > file, but an operator might only refer to this file and so the difference > should be expressed here (and in vtep-ctl.8.in) as well. > sure, it may be helpful > > > [snip] > > > diff --git a/vtep/vtep-ctl.8.in b/vtep/vtep-ctl.8.in > > index 129c7ed..f0da108 100644 > > --- a/vtep/vtep-ctl.8.in > > +++ b/vtep/vtep-ctl.8.in > > @@ -195,6 +195,21 @@ combination on the physical switch \fIpswitch\fR. > > List the logical switch bindings for \fIport\fR on the physical switch > > \fIpswitch\fR. > > . > > +.IP "\fBset\-replication\-mode \fIlswitch replication\-mode\fR" > > +Set logical switch \fIlswitch\fR replication mode to > > +\fIreplication\-mode\fR; the only valid values presently for replication > > +mode are "service_node" and "source_node". > > +. > > +.IP "\fBget\-replication\-mode \fIlswitch\fR" > > +Get logical switch \fIlswitch\fR replication mode. The only valid > values > > +presently for replication mode are "service_node" and "source_node". > > +A return value of NULL indicates the replication mode column is not set > > +and therefore a default of "service_node" is implied. > > +. > > +.IP "\fBreset\-replication\-mode \fIlswitch\fR" > > +Reset a logical switch \fIlswitch\fR replication mode to the default of > > +"service_node". > > +. > > Please also include a description of the difference in what happens > between the two replication modes here as well. > earlier comment applies > > > Ryan Moats > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
