On Fri, Apr 22, 2016 at 07:43:14PM -0700, Jarno Rajahalme wrote: > cmap implements duplicates as linked lists, which causes removal of > rules to become (O^2) with large number of duplicates. This patch > fixes the problem by introducing a new 'counting' variant of the cmap > (ccmap), which can be efficiently used to keep counts of inserted hash > values provided by the caller. This does not require a node in the > user data structure, so this makes the user implementation a bit more > memory efficient, too. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org>
I did not carefully reread the code (I think I did an OK job on v1) but I did build to make sure there were no warnings etc., and I did run the test. Let me know if you want a thorough (re)review. There's a typo in the test name: s/cockoo/cuckoo/, also I'd add ccmap to the AT_KEYWORDS there. Thank you. Acked-by: Ben Pfaff <b...@ovn.org> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
