On Sat, May 07, 2016 at 04:22:44PM -0700, Justin Pettit wrote: > > > On May 6, 2016, at 1:10 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > @@ -448,10 +441,11 @@ nbctl_lswitch_add(struct ctl_context *ctx) > > static void > > nbctl_lswitch_del(struct ctl_context *ctx) > > { > > + bool must_exist = !shash_find(&ctx->options, "--if-exists"); > > In addition to my previous comments, I just noticed this variable should > probably be called "if_exists".
must_exist is the negation of --if-exists. Same logic as in ovs-vsctl for similar command (in fact, cut-and-paste). > > @@ -576,9 +642,10 @@ remove_lport(const struct nbrec_logical_switch > > *lswitch, size_t idx) > > static void > > nbctl_lport_del(struct ctl_context *ctx) > > { > > + bool must_exist = !shash_find(&ctx->options, "--if-exists"); > > Same here. Ditto. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev