On Tue, May 10, 2016 at 3:40 PM, Joe Stringer <j...@ovn.org> wrote: > On 10 May 2016 at 10:37, pravin shelar <pshe...@ovn.org> wrote: >> On Fri, May 6, 2016 at 9:23 AM, Ben Pfaff <b...@ovn.org> wrote: >>> On Mon, Apr 25, 2016 at 03:58:33PM -0700, Pravin B Shelar wrote: >>>> The neighbor entry expiry is only checked in dpif-poll >>>> event handler, But in absence of any event we could keep >>>> using arp entry forever. This patch changes it to check >>>> expiration on each lookup. >>>> >>>> Signed-off-by: Pravin B Shelar <pshe...@ovn.org> >>> >>> I guess an alternative would be to introduce a "wait" function to make >>> sure that expiration happens more expeditiously, but this seems fine >>> too. >>> >>> The locking in this module seems a little heavy-handed given that we're >>> using a cmap. >>> >> I am not sure if arp lookup locking is a bottleneck at this point but >> I am planing on benchmarking tunnel performance. it can be addressed >> then. >> >>> Acked-by: Ben Pfaff <b...@ovn.org> >> >> Thanks. I pushed it to master. > > Do you think that this patch might cause reordering of the output of > ovs-appctl tnl/arp/show ? > > https://travis-ci.org/openvswitch/ovs/jobs/129264117#L7455
I am not sure why would it cause reordering. I do not see this issue on my test setup, anyways I have sent out patch to fix this issue. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
