The pull request seems OK to me. Justin, do you have an opinion on this patch?
On Wed, May 18, 2016 at 06:22:23PM +0800, nickcooper-zhangtonghao wrote: > Hi Ben, > Thank you for your advice. In general case, we run an ovs-vtep process > on the hypervisor. > In our network virtualization solution, we want to run multiple copies of the > vtep simulator - ovs-vtep for the different network, > such as the data/management/storage network. > > Start the VTEP emulator: > ovs-vtep --detach mgmt-network > ovs-vtep --detach stor-network > ovs-vtep --detach data-network > > Bind the logical switch to a port: > vtep-ctl bind-ls mgmt-network vnet0 0 ls0 > vtep-ctl bind-ls stor-network vnet1 0 ls1 > vtep-ctl bind-ls data-network vnet2 0 ls2 > > > In fact, the vnet0/vnet1/vnet2 have been connected to the “vtep_ls1” bridge. > So, the VMs of the different physical switches have been connected. > This is arguably an ovs-vtep bug. I fixed this bug by including the physical > switch name as part of the logical switch name. > Darrell Ball did an initial test using the OVN gateway test case and did not > see any issues with the proposed diff. > I have submited a pull request. https://github.com/openvswitch/ovs/pull/126 > <https://github.com/openvswitch/ovs/pull/126> > > > > Thanks， > nickcooper-zhangtonghao. > > > > On May 18, 2016, at 10:26 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > On Sun, May 01, 2016 at 01:44:26PM +0800, nickcooper-zhangtonghao wrote: > >> signed-off-by: nickcooper-zhangtong...@opencloud.tech > >> <mailto:nickcooper-zhangtong...@opencloud.tech> > >> > >> The computer can run multiple ovs-vtep processes, but ovs-vtep processes > >> share the “vtep_lsX” bridge when binding the physical-switch and > >> logical-switch. The bridge created by logical-switch should be named > >> according to logical-switch. > > > > Hi Nick, thanks for submitting a patch. > > > > You'll need to resubmit it for a number of reasons. > > > > Your return email address was totally wrong and definitely not usable. > > I think I've corrected it; we'll see if my reply bounces. > > > > Please use a short (<75 character) title. > > > > Please limit lines in the commit message to 75 characters or so. > > > > "Signed-off-by" goes at the end of the message and it should be > > formatted as: > > Signed-off-by: Your Real Name <email@host> > > not as you did it. > > > > Thanks, > > > > Ben. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
